https://bugs.gpodder.org/show_bug.cgi?id=1391
Bug #: 1391
Summary: checking that a previous update didn't happen at a
time later than 'now' is unnecessary/confusing
Classification: Unclassified
Product: gPodder
Version: 2.16+ (Git "master" branch)
Platform: PC
OS/Version: Linux
Status: UNCONFIRMED
Severity: minor
Priority: low
Component: Application
AssignedTo: [email protected]
ReportedBy: [email protected]
CC: [email protected]
Created attachment 647
--> https://bugs.gpodder.org/attachment.cgi?id=647
remove superfluous check, replace with an assert
When processing notifications from a media player about 'play' actions, we
check to see that the previous update didn't occur at a time later than 'now',
and only if it didn't do we update with the new action. This seems unnecessary
(and is therefore confusing): the only way that a previous action could have
happened before 'now' is if one or the other of the timestamps being compared
is incorrect --- in which case it's probably still correct to update with the
new action?
If the check was put in for a specific reason, I think it should be clarified
with a comment; otherwise, I think it can be safely removed. The attached patch
asserts that the condition is true (I'll run with this for a while just to see
what happens), though I would just as soon get rid of that, too.
Attached patches against master and tres.
--
Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
gPodder-Bugs mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-bugs
