https://bugs.gpodder.org/show_bug.cgi?id=1013
--- Comment #12 from Thomas Perl <[email protected]> 2012-02-05 14:13:49 GMT --- (In reply to comment #11) > Created attachment 687 [details] > Okay, maybe this one hits the spot :) > > Spit, polish and adaptation to the json config tree Some quick feedback on the patch: 1. "write_only_variable" should be renamed to "_": for _ in range(max(1, self._config.auto.retries+1)): ... 2. Make the call to downloader.retrieve_resume only appear once (you can remove the second call if you change the "for loop" statement to the one that you find above) 3. Write the "continue" statements in their own lines, don't make them "stick" to the end of the previous line after the ":" 4. >>if "timed out" in e.strerror<< might not work if a different locale is set - use errno for that (is that errno 12 or ETIMEDOUT?) 5. The "retries": 3 in config.py could use a helpful comment.. -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
