https://bugs.gpodder.org/show_bug.cgi?id=1303
Jonas Kölker <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #693 is|0 |1 obsolete| | --- Comment #4 from Jonas Kölker <[email protected]> 2012-02-06 15:35:01 GMT --- Created attachment 694 --> https://bugs.gpodder.org/attachment.cgi?id=694 Incorporating ThP's suggestions I tried to incorporate your ideas, Thomas. A few comments: I made the import argument "FILENAME|URL" rather than "URL|FILENAME" for symmetry with the export argument. src/gpodder/opml.py#{Im,Ex}porter.__init__ do their own error handling. I don't think it's necessary for me to pile more on top of this. There seems to be some redundant error handling between bin/gpo#gPodderCli.subscribe and src/gpodder/api.py#PodcastClient.create_podcast, in particular relating to my pokemon exception handling (gotta' catch them all). I've updated my error handling, but maybe I could do something similar to what opml.py does with the logger? I used os.path.curdir instead of '.'; my Anal Retentive Personality Disorder compels me to :-) -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
