[gpodder-bugs] [Bug 1288] Unify cover art downloading / loading and fix file name extensions (.jpg, .png)

[bugs]

https://bugs.gpodder.org/show_bug.cgi?id=1288

Thomas Perl <t...@gpodder.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |IN_PROGRESS
            Version|2.12                        |Git "master" branch
            Summary|gpodder saves image as      |Unify cover art downloading
                   |folder.jpg even if it's a   |/ loading and fix file name
                   |png                         |extensions (.jpg, .png)

--- Comment #2 from Thomas Perl <t...@gpodder.org> 2012-03-01 10:22:32 GMT ---
Steps to be done:

 * Unify the downloading code:
   - src/gpodder/gtkui/services.py: CoverDownloader.__get_cover
   - src/gpodder/qmlui/images.py: LocalCachedImageProvider.requestImage

   => into new module gpodder.coverart

The unified downloading code needs the following arguments:
   - filename w/o extension (template), e.g. ~/gPodder/Downloads/ABC/folder
   - download URL of cover image
   - podcast feed URL
   - podcast title (for auto-generating / hashing)
   - podcast username and password

The unified downloading code needs to utilize the following functions:
   - youtube.get_real_cover(podcast_url) -> Resolves YouTube cover art
   - util.url_add_authentication -> Add username/password (if any)

The following functions should be moved to the unified downloading code:
   - util.podcast_image_filename
   - util.cover_fallback_filename

The code should be able to operate asynchronously (via a callback) and
synchronously. The result of the function should be a filename that can be
opened and read by the toolkit in use. A filename should be returned in all
cases (use the fallback cover art for this).

To replace the "gpodder:episode-subset-view" filename in
src/gpodder/qmlui/images.py, a special scheme should be used instead (e.g.
"x-gpodder-icon://podcast-all").

Other considerations:
   - src/gpodder/model.py: PodcastChannel.check_download_folder
                           must handle folder.png and friends
   - src/gpodder/dbusproxy.py: Must handle the cover_file property correctly
   - Should the CLI (bin/gpo) also support downloading cover art?
   - Should cover art be auto-generated when not available? Can it use
     the podcast title and stylize it over a generic, colored RSS icon?
   - Are other formats (e.g. .svg) to be supported?

-- 
Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
gPodder-Bugs mailing list
gPodder-Bugs@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/gpodder-bugs