https://bugs.gpodder.org/show_bug.cgi?id=1491
--- Comment #7 from Thomas Perl <[email protected]> 2012-03-11 09:40:33 GMT --- (In reply to comment #6) > the branch is the master-3.1-rebase on > https://github.com/brot/gpodder I've reviewed your changes. The updated merge branch is here: https://github.com/gpodder/gpodder (branch: brot-merging) Extensions feedback: - The extensions shouldn't know the "deep" path to their config, so I've removed the deep path and added it to src/gpodder/extensions.py (this has the nice side-effect that it will automatically be right if the extension gets renamed or forked) - The container has a require_command() function that resolves commands and also raises a special dependency exception when it's not found, we can handle this from outside. Use this to check for commands - don't raise an exeption by yourself in the extensions - Use single quotes (') instead of double quotes (") for strings - Use literal byte strings ('') instead of unicode strings (u'') - Don't try..except imports -> we'll handle these from "outside" - Use self.container.require_command() to check dependencies (this will raise an exception or return the full path if it exists, and it will also take care of .exe and .bat filenames) - on_load and on_unload should only be used if they do anything useful - normalize_audio and mp3gain do the same thing - can we merge them and make the "method" configurable? - rename_download now takes care of avoiding rename conflicts. Should we also have a pattern-based configuration item for deciding how the episode files will be named (for more flexibility) - tfh_shownotes should probably be in your "extras extensions" repo and - Avoid shlex.split() and try to use lists for command lines (e.g. ['ffmpeg', 'a', filename] instead of 'ffmpeg a %(filename)s') The GUI already takes care of showing the error to the user. Imports are also handled (an error is shown) if you don't try..except them. -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
