https://bugs.gpodder.org/show_bug.cgi?id=1598

Thomas Perl <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |IN_PROGRESS
   Target Milestone|---                         |3.2
     Ever Confirmed|0                           |1

--- Comment #1 from Thomas Perl <[email protected]> 2012-05-13 06:20:20 BST ---
Thanks for the patch. It's good, but it assumes that all byte strings are
encoded in utf-8, which might not always be the case. Please have a look at the
convert_bytes() function in src/gpodder/util.py and use it to convert byte
strings to unicode strings and resubmit the patch, I'll apply it then :)

Also, please make sure to use your full name (Firstname Lastname) for the
commits - see http://help.github.com/set-your-user-name-email-and-github-token/
for how to do it (ignore the "Github token" part). The commit message should be
properly formatted, e.g.:

gpo: Fix line length calculation for byte strings (bug 1598)

gpo incorrectly calculates the length of podcasts containing non-ASCII
characters (e.g. Russian ones), which results in the "[DONE]" label being
closer to the message and not aligned with other "[DONE]" labels. This
patch fixes it by converting byte strings to unicode before calculating
the string length, resulting in properly aligned output.

-- 
Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
gPodder-Bugs mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-bugs

Reply via email to