https://bugs.gpodder.org/show_bug.cgi?id=1676
--- Comment #5 from Thomas Perl <[email protected]> 2012-09-30 08:49:45 BST --- (In reply to comment #4) > Created attachment 741 [details] > Some cleanup > > Ok, I cleaned up the patch following your suggestions (removed > src/gpodder/qmlui/model.py and used datetime.date). > > As for the frequency implementation choice ("day of the week" vs "every X > days"): my experience is that nearly all non-daily podcasts have a fixed > weekly > release day (e.g. (web)radio shows), so it makes more sense to choose the day > of the week, rather than every X days (which would also complicate the > implementation). > > But maybe other users have different needs, I'll ask for comments on the > mailing list. While you are at it, maybe we should refactor at this point: Add a new method "should_update()" that will check the weekday and the pause_subscription flag. Then you can grep for all usages of pause_subscription and (where it makes sense, i.e. pause_subscription is read for determining if a feed update takes place) replace them with .should_update(). This way, we have a central place where we can enable/disable feed updates, and future changes are easier (you also get integration into the CLI and QML UI "for free" this way, as both of them already handle the pause_subscription flag). -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
