https://bugs.gpodder.org/show_bug.cgi?id=1711
Thomas Perl <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |CONFIRMED AssignedTo|[email protected] |[email protected] Ever Confirmed|0 |1 --- Comment #1 from Thomas Perl <[email protected]> 2012-11-14 10:57:04 GMT --- Sounds like a very good idea to me. Required code changes (just personal notes): - src/gpodder/gtkui/desktop/podcastdirectory.py (get_selected_channels must return a list of (title, url) pairs instead of just urls) - src/gpodder/gtkui/main.py (add_urls_callback, i.e. gPodder.add_podcast_list must deal with (title, url) pairs instead of just urls, also check all calls to self.add_podcast_list() in this file) - src/gpodder/gtkui/interface/addpodcast.py (in on_btn_add_clicked, we must supply a (title, url) pair to add_urls_callback()) As the "Add podcast" dialog does not have a title, we have several possibilities: - Use None as the title value, and handle that accordingly - Allow the user to enter a title during "add podcast", too (possibly already downloading / detecting the title while the user enters a URL? or make it optional) More notes: - In add_podcast_list(), after the call to self.model.load_podcast it should be enough to say channel.title = <desired title> and then channel.save() - If we do that, then in progress.on_message(url) we could use the title (if available) which makes the progress dialog nicer to the user (showing the podcast title instead of the URL) - A side-effect of this is that by default all subscriptions from the example podcasts and podcast directory / podcast directory search will also have the title taken from the directory entry, and not directly from the feed (given that we might "cleanup" podcast titles automatically on gpodder.net [not sure if we do right now], this might be a good thing to have or something that's not that good) As far as I know (and I've just tested this), custom titles are already exported into the OPML file, and they even show up in the selection dialog when you load the OPML file. It's just that the titles are lost from the dialog to the real subscription, because all the dialog gives back is a list of URLs to subscribe to. -- Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. _______________________________________________ gPodder-Bugs mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-bugs
