https://bugs.gpodder.org/show_bug.cgi?id=1730

--- Comment #14 from [email protected] 2013-01-08 01:53:05 GMT ---
I could install ifconfig which would fix my immediate problem but that would
not fix the larger issue. 

This code in the merged patch

elif len(list(linux_get_active_interfaces())) > 0:
 return True

will never be run. The first call to unix_get_active_interfaces will either run
successfully and return if ifconfig is installed or crash because calling
ifconfig doesn't succeed. 

It would seem to make more sense to me to check if ip or ifconfig is installed
and then run either linux_get_active_interfaces or unix_get active_interfaces.
Even better might be to rename them {ip,ifconfig}_get_active_interfaces since
it is less a distinction between linux/unix and more between which command you
are checking for interfaces with. Of course I am not familiar with the gpodder
code so I'm unsure what the best solution may be.

I did post my quick and dirty solution earlier that fixes the problem for me by
checking if gpodder is running on linux and then running
linux_get_active_interfaces. There are obvious issues with that though.

-- 
Configure bugmail: https://bugs.gpodder.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
gPodder-Bugs mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-bugs

Reply via email to