Hello, Nick! On Wed, 2007-08-08 at 22:42 -0400, nikosapi wrote: > I found this bug that's been bugging me for a couple of days in the > libipodsync code. If you have a channel with more than one new episode > and try to sync the channel it will only copy the older one first. > Then you sync again and it'll copy the second oldest one. That keeps > going till there are no new episodes. > > The attached one-liner patch fixes that and I don't think it disturbs > anything else. The function the if statement is testing should always > be returning True, but for some odd reason the function was returning > None. When it synced an episode that 'None' stopping the the rest of > that channel from being synced.
I am stupid and shouldn't code with my brain in suspend mode. Of course, the function should return True at the end of the function body when the function exits normally, then the "if" also works again (it's good that the sync process ends when add_episode_from_channel returns a False value, because this means the sync process should stop). Trivial fix applied to current svn head trunk. Thomas _______________________________________________ gpodder-devel mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-devel
