Hello, Alistair!

On Wed, 2007-08-15 at 18:40 +0100, Alistair Sutton wrote:
> I noticed the other day that the videos from the DL.TV Divx feed were
> not being synced along with the rest of the podcasts.
> 
> I added "divx" alongside the rest of the video filetypes in
> libipodsync.py and libpodcasts.py and then everything worked as
> expected. Of course, I'm not entirely sure if it needs to be added to
> both files.
> 
> Any chance this can be added to svn before the next release? 

I've attached a patch - does this patch fix your issue (.divx extension
used as "mp4" in iPod sync and detected as "video" in the video
detection code)?

Tell me if it works, and if so, I'll commit it to our svn repository and
it will be available in the next release.


Thanks,
Thomas

Index: src/gpodder/libpodcasts.py
===================================================================
--- src/gpodder/libpodcasts.py	(revision 368)
+++ src/gpodder/libpodcasts.py	(working copy)
@@ -453,7 +453,7 @@
     def get_file_type( self, item):
         types = {
                 'audio': [ 'mp3', 'ogg', 'wav', 'wma', 'aac', 'm4a' ],
-                'video': [ 'mp4', 'avi', 'mpg', 'mpeg', 'm4v', 'mov' ],
+                'video': [ 'mp4', 'avi', 'mpg', 'mpeg', 'm4v', 'mov', 'divx' ],
                 'torrent': [ 'torrent' ]
         }
         extension = splitext( self.getPodcastFilename( item.url))[1][1:]
Index: src/gpodder/libipodsync.py
===================================================================
--- src/gpodder/libipodsync.py	(revision 368)
+++ src/gpodder/libipodsync.py	(working copy)
@@ -98,8 +98,8 @@
     global enable_ipod_functions
     return enable_ipod_functions
 
-# file extensions that are handled as video
-video_extensions = [ "mov", "mp4", "m4v" ]
+# file extensions that are handled as video (divx can be handled as mp4??)
+video_extensions = [ "mov", "mp4", "m4v", "divx" ]
 
 # is mplayer available for finding track length?
 use_mplayer = False
_______________________________________________
gpodder-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-devel

Reply via email to