On September 28, 2007 08:48:03 Thomas Perl wrote:
> Hello, Nick!
>
> On Thu, 2007-09-27 at 20:52 -0400, nikosapi wrote:
> > Another bug which I didn't have a chance to look into was that I
> > couldn't cancel a download that is in progress. If I have time, I'll
> > look into it this weekend (if you didn't already get to it).
>
> You shouldn't change the download thread's "url" attribute, as this is
> used to find the right episode to cancel. I wonder if you need the
> URL-changing part of your patch at all, because if you look at the top
> of the gpodder.download module, I already do the authentication part. I
> think the only thing needed from your patch is the "load_settings()"
> call on the channel when creating them from the channels.opml file.
>
>
> Thomas
>
Hi Thomas,
To quote Moss from the IT Crowd, "Egg and my face were in alignment." :D
I kept wondering what what the hell prompt_user_passwd( self, host, realm) was
for! I guess I didn't pay attention to the fact that it's part of a
urllib.FancyURLopener class. I shouldn't have second guessed your code :)
The attached patch is just the fix to load the channel settings on start-up.
Have a good day,
nick
diff -u gpodder-r433/src/gpodder/libpodcasts.py gpodder-r431-dev/src/gpodder/libpodcasts.py
--- gpodder-r433/src/gpodder/libpodcasts.py 2007-09-27 20:19:46.000000000 -0400
+++ gpodder-r431-dev/src/gpodder/libpodcasts.py 2007-09-27 20:28:33.000000000 -0400
@@ -663,7 +663,9 @@
for item in importer.items:
callback_proc and callback_proc( count, len( importer.items))
callback_url and callback_url( item['url'])
- result.append( podcastChannel.create_from_dict( item, load_items = load_items, force_update = force_update, callback_error = callback_error, offline = offline))
+ channel = podcastChannel.create_from_dict( item, load_items = load_items, force_update = force_update, callback_error = callback_error, offline = offline)
+ channel.load_settings()
+ result.append( channel)
count += 1
return result
_______________________________________________
gpodder-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/gpodder-devel
