Hello Thomas,
Thomas
Perl a écrit :
Hello,
Jérôme!
Today, I've had some time to review your patch, I've attached my
modifications.
Thank you for taking the time to review it. I am still actively working
on it. I had a quick look at your modifications and most of them are
very pertinent. I will apply them to my working copy.
I hope to be able to deliver you an almost finalised version for
testing (let say a beta version) before the end of this week, with most
of my todo list
implemented (+ action in notification)
I've
changed the file name to "trayicon" to fit better in the overall
gPodder module naming scheme.
I am thinking of separating the statusIcon and the notifier parts in
two differents classes. If I'll do so, I'll change the name again,
else, I'll keep your.
There are
still some things that need to be done:
* Degrade gracefully when python-notify is not installed
My opinion: at very first run, gPodder should check all this mandatory
and optional modules installed (libnotify, feedparser, python-gpod...),
diplay a nice box listing the ones missing and explained what for they
are used. At later run, gPodder should not complain anymore, the nice
box would be still accessible from the "help" menu.
*
"Update feeds" should be possible without the dialog
I´m working on it. A well as automatic downloading new feeds (without
dialog at all) when gPodder isn't visible. (remember, my goal is to
have it running in background with just the tray icon)
*
"Download all new episodes" should display only the episode selector
if the gPodder main window is hidden and not the gPodder main window
It should be possible, I'll try it
* Configuration options, as metioned in the TODO comments
Tray icon configuration options (a proposal):
* No tray icon
* Minimize to tray (only show icon when minimizing the window)
* Always show tray icon (as it is currently)
Notification configuration options:
* No notifications (error messages in message dialogs)
* Notifications when minimized (including error messages)
* Always use notifications (error messages in notification bubbles)
Good ideas. I'll try to implement them also.
I've also
attached the notification to the tray icon, which looks better in my
opinion (after all, the tray icon "says" what the message contains).
I can only agree with you, since I also did it I my working copy ;).
Jérôme
Chabod wrote:
I send you a new patch (for revison 503):
Pieter De Decker a écrit :
I have two of things to say about the
notifications:
- Try to make them a little more descriptive. I'm sure that you've
already thought of that and that you're working on it, but there's
more. What if a certain episode is called "My super duper special
podcast episode with a special guest host for December 21st 2007"? You
could solve this by limiting the episode name to the first 25 (or so)
characters, followed by "(...)". Example: "'My super duper special
po(...)' has been downloaded successfully".
You'll probably like this version. I don't notify every file download
because it's very annoying having to much popup windows, but the
tooltip displays during dowload already dowloaded files, and the notify
also lists them
Very good idea, I've improved the code a little to be a bit faster
(''.join() instead of string concatenation).
I notice you chose to cut long title a the end (blabla(...))where I
chose to cut them on the middle (bla(...)bla). My idea was that the
important information is often at the beginning or at the end
of the name. For instance, many of my episodes titles are something
like "Actualité et divertissement blablabla 25/12/2007 17h40". Most of
my feed have the same way the date at the end.
nikosapi a écrit :
Attached is a very basic autoupdate
addition to your patch. What it does, is every 20min it runs
update_feed_cache. This behaviour is controlled by a configuration
option in the Preferences window.
Can you re-integrate Nick's patch? I have not yet had time to look into
it. Maybe the patches should be seperated and one applied independent
of the other.
I will try to integrate it manualy. Did you succed to apply this patch?
Thomas Perl a écrit :
get_tree_icon() from gpodder.util could be
helpful here. This is the function that is used to add the bullet or
padlock to the icons in the episode list. You could extend this
function and be able to get the gPodder icon with some "downloading"
(e.g. arrow down) or checking (e.g. the "refresh" icon) in the lower
right-hand corner of the icon.
I used you code as inspiration but I had my own method for more
flexibility (I use a dictionary, it's quite easy to add as status)
Looks good, I've improved and simplified that a little.
Your solution really improve the code.
Basically, the user is already notified
about errors. What needs to be done is to redirect the
show_notification() (and probably also show_confirmation()?) calls to
the tray icon (and therefore libnotify) if the gPodder window has been
hidden and only the tray icon is visible.m
I´ll check this
Have you had time looking into this already?
I started implenting it. It's already looks good.
I've
simplified some parts of your class so that it hopefully is easier to
maintain.
What do you think of my modifications and the suggestions above?
Good work boss ;)
Jérôme
|
