Hello, Nick! On Fri, 2008-03-28 at 11:11 -0500, nikosapi wrote: > Thank you for looking over and improving my code :) > > I added one small thing, if find_mount_point() returns '/' then to > prevent find_scrobbler_log() from os.walk()'ing your whole root > filesystem we simply set mp3_player_mount_point to the the directory > that we're syncing to. Appart from that I think the patch is ready.
Thanks, I've applied your patch as-is to SVN trunk :) > Ideally the .scrobbler.log file should be cleaned by scrobbler > software that submits tracks to last.fm. I wrote a small python module > that can scrobble tracks but I don't really think that it belongs in > gPodder. (Unless you really think otherwise...) Yes, I also think that the clean-up has to be taken care by the last.fm client, that's what the spec also says. I just wondered if rockbox had any kind of intelligence built-in that would make sure the file didn't grow endlessly if the file is never deleted by a last.fm client (as is the case when one enables this feature for the sole purpose of getting played state synchronization to work with gPodder, without ever using last.fm). Thomas _______________________________________________ gpodder-devel mailing list gpodder-devel@lists.berlios.de https://lists.berlios.de/mailman/listinfo/gpodder-devel
