Thanks to your attention, I'll check your patch asap, tomorrow or in monday. 2008/5/24, Thomas Perl <[EMAIL PROTECTED]>: > Hello! > > > On Fri, 2008-05-23 at 02:30 +0600, Leonid Ponomarev wrote: > > attached patch provide some sync statistics functionality to gpodder, > > use gpodder -S or gpodder --stats. > > > Thanks. As this is quite a small patch and isn't as intrusive as the > other one, I've fixed it up a bit and am attaching it to this mail for > you to have a look at. You might want to open a bug report and attach > the patch there, so we can have the discussion about the patch and > possible changes in there. > > I've also added support for iPods :) > > > > Maybe there's a place for it in gui too. Maybe there's a need to make > > corresponding checks before each sync. > > > Yes, that would be very helpful, possibly also offering the user to > delete old episodes from the device (I imagine a simply > show_confirmation asking the user to delete episodes before syncing > should do the trick). It should not be too hard to implement, simply > move the code for calculating the sync size to podcastChannel in > libpodcasts, the code for calculating the free disk space is already in > the gpodder.sync module. Then, the check can be a simple > "channel.get_sync_size() <= device.get_free_diskspace()" or so. > > > > New function sync_stats return true or false depending on whether > > there's enough space on device to sync all suitable episodes. > > > Maybe we should change the naming of these functions. It's not really > "sync stats" but "sync free diskspace check" or something like that. > Maybe "sync disk usage" would be nice, and we should be able to > determine the used disk space for a device, because we can get the files > and their sizes and calculate the used disk space there. > > Looking forward to your improved patch, it looks really promising! > > > Thanks, > Thomas > > _______________________________________________ > gpodder-devel mailing list > [email protected] > https://lists.berlios.de/mailman/listinfo/gpodder-devel >
-- Best regards, Leonid "PhoeniX" Ponomarev Jabber: [EMAIL PROTECTED] _______________________________________________ gpodder-devel mailing list [email protected] https://lists.berlios.de/mailman/listinfo/gpodder-devel
