I thought we had fixed all of these, but I'm building/testing git master (to verify that WRITE_PAD is still needed), and see the following warnings in the build. This is the signature of invoking a ctype(3) function with type char, which could be signed, and if negative, would be promoted to a negative int, which gets you into UB, per ISO C -- the only allowable values are those representable as unsigned char and EOF.
I'll see about fixing, but when editing be careful to use these functions correctly -- which is hard. gpsd-3.27.6~dev/gpsd/gpsd_json.c:79:21: warning: array subscript has type ‘char’ [-Wchar-subscripts] gpsd-3.27.6~dev/gpsd/gpsd.c:959:22: warning: array subscript has type ‘char’ [-Wchar-subscripts] gpsd-3.27.6~dev/gpsd/gpsd.c:960:23: warning: array subscript has type ‘char’ [-Wchar-subscripts] gpsd-3.27.6~dev/gpsd/gpsd.c:1192:24: warning: array subscript has type ‘char’ [-Wchar-subscripts] gpsd-3.27.6~dev/gpsd/gpsd.c:1201:32: warning: array subscript has type ‘char’ [-Wchar-subscripts] gpsd-3.27.6~dev/gpsd/gpsd.c:1285:20: warning: array subscript has type ‘char’ [-Wchar-subscripts] gpsd-3.27.6~dev/gpsd/gpsd.c:1661:30: warning: array subscript has type ‘char’ [-Wchar-subscripts] gpsd-3.27.6~dev/gpsd/gpsd.c:2090:25: warning: array subscript has type ‘char’ [-Wchar-subscripts]
