"Gary E. Miller" <[email protected]> writes: >> I have tested, and on NetBSD 11 amd64 get no build warnings at all! > > Good news. > > I don't like the solution of just casting to (unsigned char). Too > brittle. I'm going to add ISXXXXX() macros that ex explicity valid for > all (int) and ASCII. The existing isXXXXX() are locale specific, and > that could byte us some time.
I don't think that's really sound in general. The functions are defined on values that fit in unsigned char, and EOF. Given the cast, it's not like EOF can be used. But EOF aliases to 255. Any particular use of an unsigned char cast is stable and safe. THe problem is that this leads to new uses of ctype functions without casts. So if there is an ISALPHA() macro: #define ISALPHA(c) isalpha((unsigned char) c) then that's a good way to encapsulate the plan and increase the odds that the next newly-added ctype call will be ok. >> And, tests pass (with the default WRITE_PAD 0.001, as has been true >> ~forever, mentioning because the ticket was poked). I have kicked >> off a build/test run on NetBSD 10 aarch64 (a RPI4) and will speak up >> if trouble, but I don't expect it. > > Lookg forward to the results. No build wanrings, regression tests pass. >> There are around 400 commits since the last release -- is it time to >> be thinking about a new micro? Or are there too-big changes? > > Yeah, every time i thinkk we are stable, a bunch of CVE's have come > in. Seems quite now. Almost tie for a release. Fingers crossed. ack, sounds good.
