Updated patch attached. Now x86_64 uses 7 for the client ID. Thanks, Geoff
VMware, Inc. is providing this patch to you under the terms of the GPL version 2 and any later version. This patch is provided as is, with no warranties or support. VMware disclaims all liability in connection with the use/inability to use this patch. Any use of the attached is considered acceptance of the above. > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of Joshua > Oreman > Sent: Friday, May 28, 2010 4:29 PM > To: Geoff Lywood > Cc: Jarrod Johnson; Stefan Hajnoczi; [email protected] > Subject: Re: [gPXE-devel] [PATCH] Use correct DHCP options on EFI > > On Fri, May 28, 2010 at 12:03 PM, Geoff Lywood <[email protected]> wrote: > > Thanks for pointing this out. TianoCore does use 7. Personally, I think > 9 > > makes much more sense, because the OS loader needs to be > > architecture-specific. Simply saying "EFI BC" is not enough information > to > > be able to load an OS. > > > > So, it's a question of whether we want to follow the standard or follow > the > > de facto standard. I'm happy to change the patch for the sake of > > compatibility if people think that is the right way to go. > > I'd go with the de facto standard, since more software that cares is > likely to support it. We can always change it later if it proves > necessary. > > -- Josh > > > > > Geoff > > > > > > > > > > > > ________________________________ > > > > From: Jarrod Johnson [mailto:[email protected]] > > Sent: Friday, May 28, 2010 6:20 AM > > To: Stefan Hajnoczi > > Cc: Geoff Lywood; [email protected] > > > > Subject: Re: [gPXE-devel] [PATCH] Use correct DHCP options on EFI > > > > > > > > FYI, IBM UEFI uses arch 7 (efi basecode) when their UEFI code executes. > > What is right or wrong, dunno, but currently this patch differs from > their > > behavior (which might inherit from TianoCore, not sure). Might want to > > double check TianoCore to see if they also use 7. I think 9 would have > been > > more precise and implied 7 and so I prefer what this patch does, thought > I'd > > just point out what is happening elsewhere in uefi. > > > > On Fri, May 28, 2010 at 1:19 AM, Stefan Hajnoczi <[email protected]> > wrote: > > > > When adding new files the FILE_LICENCE() macro should be used. For > > example, include/gpxe/list.h uses the macro. > > > > include/compiler.h has the macro and possible license constants. > > > > The build system has .license targets (e.g. make > > bin/10ec8139.rom.licence) which give a breakdown of licensing for all > > involved files. > > > > Would it be possible for you to add this? > > > > Thanks, > > Stefan > > > > _______________________________________________ > > gPXE-devel mailing list > > [email protected] > > http://etherboot.org/mailman/listinfo/gpxe-devel > > > > > > > > _______________________________________________ > > gPXE-devel mailing list > > [email protected] > > http://etherboot.org/mailman/listinfo/gpxe-devel > > > >
0001-Use-correct-DHCP-options-on-EFI-systems.-RFC-4578.patch
Description: 0001-Use-correct-DHCP-options-on-EFI-systems.-RFC-4578.patch
_______________________________________________ gPXE-devel mailing list [email protected] http://etherboot.org/mailman/listinfo/gpxe-devel
