On Fri, May 28, 2010 at 8:47 PM, Geoff Lywood <[email protected]> wrote: > Josh, > > Thanks for prodding me into testing this on more systems. It turns out that I > needed a fix for 32-bit gcc as well. > > Now tested with: > - e1000e on Apple Xserve > - SNP (the other patch I'm currently cleaning up) on Apple Xserve > - SNP on IBM x3550 > - e1000 in a VM with 32-bit EFI > - e1000 in a VM with 64-bit EFI > > Try #2 is attached.
Merged: http://git.etherboot.org/?p=gpxe.git;a=commit;h=19dfdc0e8c48e7d3c7971e98200b218ce78a5780 Thanks for your contribution! -- Josh > > Thanks, > Geoff > > > VMware, Inc. is providing this patch to you under the terms of the GPL > version 2 and any later version. This patch is provided as is, with no > warranties or support. VMware disclaims all liability in connection with the > use/inability to use this patch. Any use of the attached is considered > acceptance of the above. > > > >> -----Original Message----- >> From: [email protected] [mailto:[email protected]] On Behalf Of Joshua >> Oreman >> Sent: Friday, May 28, 2010 4:48 PM >> To: Geoff Lywood >> Cc: [email protected] >> Subject: Re: [gPXE-devel] [PATCH] Update EFI headers >> >> On Fri, May 28, 2010 at 4:45 PM, Geoff Lywood <[email protected]> wrote: >> > The attached patch is the result of running the import.pl script against >> > today's TianoCore svn (rev 10551). >> > >> > Three other changes were necessary: >> > >> > - Update to efi_smbios.c because the name of the SMBIOS table >> GUID >> > changed. >> > >> > - Edit src/include/gpxe/efi/Base.h to remove a conflicting >> > definition of the "PACKED" macro. >> > >> > - Make sure that __attribute__((ms_abi)) is specified on X64 >> >> +1 pending clarification that the new headers have been tested on some >> real systems and work. I'll apply in 24 hours or after such >> clarification has been made. >> >> -- Josh >> >> > >> > Thanks, >> > >> > Geoff >> > >> > >> > >> > VMware, Inc. is providing this patch to you under the terms of the GPL >> > version 2 and any later version. This patch is provided as is, with no >> > warranties or support. VMware disclaims all liability in connection with >> the >> > use/inability to use this patch. Any use of the attached is considered >> > acceptance of the above. >> > >> > _______________________________________________ >> > gPXE-devel mailing list >> > [email protected] >> > http://etherboot.org/mailman/listinfo/gpxe-devel >> > >> > > _______________________________________________ gPXE-devel mailing list [email protected] http://etherboot.org/mailman/listinfo/gpxe-devel
