> Does be32_to_cpu() make sense instead of bswap_32()? It would be nice not to > assume a little-endian CPU. There is another bswap_32() a few lines down.
I agree it's nice not to assume little-endian, but I'll use the equivalent 'ntohl()' instead, because ntohl() is used elsewhere in myri10ge.c, and because the rest of gPXE favors ntohl() over be32_to_cpu() by a factor of 94 to 21, not counting the references in myri10ge.c. Thanks for catching this. Expect a revised patch set shortly. --Glenn _______________________________________________ gPXE-devel mailing list gPXE-devel@etherboot.org http://etherboot.org/mailman/listinfo/gpxe-devel
