Looks good.  It's nice to see high-end hardware that can be driven in
a clean and simple way.

My only suggestion is that myri10ge_net_close() should not error
outstanding TX.  The net device core code already does this in
net/netdevice.c:netdev_tx_flush().  This function is called right
after the driver's close() returns in net/netdevice.c:netdev_close().

Stefan
_______________________________________________
gPXE mailing list
[email protected]
http://etherboot.org/mailman/listinfo/gpxe

Reply via email to