Since JCR is a acronym, JcrMappingException should be JCRMappingException.

Raj

Martin Koci wrote:

and all try - catch construct should look like:
catch (Exception e)
       {
throw new JcrMappingException("Impossible to add the node : " + parentNode, e); // WITH ROOT EXCEPTION
       }

not 'throw new JcrMappingException("Impossible to add the node : " + parentNode); '. This masks trivial exceptions like NPE.

Martin

Martin Koci wrote:

Hi,
I think org.apache.portals.graffito.jcr.persistence.objectconverter.ObjectConverter methods should return new inserted Node (with method 'insert') and method 'update' updated javax.jcr.Node. Return values can be used for testing.

Christophe Lombart wrote:

Hi all,
I just commited some code refactoring. Can you vote for the PersistenceManager API & the Mapper API ? We can expect to see some modification on thoses components when we
will add new features.

See on :
* org.apache.portals.graffito.jcr.persistence.PersistenceManager
* org.apache.portals.graffito.jcr.mapper.Mapper.

You can also check the current impletation. Let me know what you want to do. I'm currently reviewing (for the secon time :-) the collection management.

Christophe








Reply via email to