Makes sense. I wonder why it was changed in the past? It used to try unzipping and check if it failed. Markus?

http://trac.osgeo.org/grass/changeset/19303

On Feb 9, 2008, at 3:25 PM, Glynn Clements wrote:


GRASS GIS wrote:

#39: r.in.srtm fails to validate zip files
------------------------ +---------------------------------------------------
 Reporter:  kyngchaos  |       Owner:  [email protected]
     Type:  defect     |      Status:  new
 Priority:  major      |   Milestone:  6.3.0
Component:  default    |     Version:  unspecified
Resolution:             |    Keywords:
------------------------ +---------------------------------------------------
Comment (by kyngchaos):

I guess my main concerns are:

* the "--mime" flag is standard on modern systems - it looks like it. * I've noticed that people tend to avoid the double-dash long versions of flags, but I don't know if there is a technical reason other than less
typing.  In this case it avoids confusion in the -i/-I short flag.

If there are no objections to "--mime", I'll patch r.in.srtm.

I'd suggest skipping the use of "file" altogether. It isn't a standard
utility on Windows.

I would assume that the filename ending in .zip is at least prima
facie evidence of the file actually being a ZIP file.

--
Glynn Clements <[EMAIL PROTECTED]>
_______________________________________________
grass-dev mailing list
[email protected]
http://lists.osgeo.org/mailman/listinfo/grass-dev

-----
William Kyngesburye <kyngchaos*at*kyngchaos*dot*com>
http://www.kyngchaos.com/

All generalizations are dangerous, even this one.


_______________________________________________
grass-dev mailing list
[email protected]
http://lists.osgeo.org/mailman/listinfo/grass-dev

Reply via email to