Hi, Thanks for pointing out all that. Strangely, I don't get those warnings here, probably command line switches... I think they are fixed now. I don't seem to have problems with centroids. Can you show me a map, on which that occurs? And again, please help with the busroute11 test, cause it's behaving weirdly.
Rosen Matev On Wed, Sep 10, 2008 at 5:58 PM, Hamish <[EMAIL PROTECTED]> wrote: > Hi, > > Glad to see things coming together. Some observations: > > #include <math.h> needs to go back into e_intersect.c for fabs() > > main.c still has a call to fmin() > > functions like Vect_point_buffer2() should have prototypes declared in > a local_proto.h file. (even if it is just temporary until it moves into > the vector libraries) > > > > besides that I get these warnings which need to be addressed. > > > dgraph.c: In function 'find_all_intersections': > dgraph.c:184: warning: unused variable 'z2_' > dgraph.c:184: warning: unused variable 'z1_' > dgraph.c:184: warning: unused variable 'y2_' > dgraph.c:184: warning: unused variable 'x2_' > dgraph.c:184: warning: unused variable 'y1_' > dgraph.c:184: warning: unused variable 'x1_' > dgraph.c:183: warning: unused variable 'res2' > dgraph.c: In function 'pg_create_struct': > dgraph.c:294: warning: unused variable 'i' > > e_intersect.c: In function 'segment_intersection_2d': > e_intersect.c:565: warning: type defaults to 'int' in declaration of 'DLEVEL' > e_intersect.c:568: warning: unused variable 'min_by' > e_intersect.c:568: warning: unused variable 'max_by' > e_intersect.c:568: warning: unused variable 'min_bx' > e_intersect.c:568: warning: unused variable 'max_bx' > e_intersect.c:567: warning: unused variable 'min_ay' > e_intersect.c:567: warning: unused variable 'max_ay' > e_intersect.c:567: warning: unused variable 'min_ax' > e_intersect.c:567: warning: unused variable 'max_ax' > > main.c: In function 'db_CatValArray_get_value_di': > main.c:48: warning: unused variable 'val_d' > main.c: In function 'main': > main.c:231: warning: implicit declaration of function 'fmin' > main.c:231: warning: incompatible implicit declaration of built-in function > 'fmin' > main.c:339: warning: incompatible implicit declaration of built-in function > 'fmin' > main.c:346: warning: implicit declaration of function 'Vect_point_buffer2' > main.c:353: warning: implicit declaration of function 'Vect_line_buffer2' > main.c:393: warning: incompatible implicit declaration of built-in function > 'fmin' > main.c:399: warning: implicit declaration of function 'Vect_area_buffer2' > main.c:124: warning: unused variable 'size_val_int' > main.c:112: warning: unused variable 'debug' > main.c:111: warning: unused variable 'dtmp' > > vlib_buffer.c: In function 'angular_tolerance': > vlib_buffer.c:130: warning: unused variable 'b' > vlib_buffer.c: In function 'parallel_line': > vlib_buffer.c:159: warning: unused variable 'r' > vlib_buffer.c:159: warning: unused variable 'sina' > vlib_buffer.c:159: warning: unused variable 'cosa' > vlib_buffer.c: In function 'convolution_line': > vlib_buffer.c:310: warning: unused variable 'r' > vlib_buffer.c:310: warning: unused variable 'sina' > vlib_buffer.c:310: warning: unused variable 'cosa' > vlib_buffer.c:459:15: warning: "/*" within comment > vlib_buffer.c: In function 'extract_contour': > vlib_buffer.c:451: warning: unused variable 'i' > vlib_buffer.c: In function 'extract_outer_contour': > vlib_buffer.c:581: warning: unused variable 'ta' > vlib_buffer.c: In function 'Vect_area_buffer2': > vlib_buffer.c:911: warning: unused variable 'max' > vlib_buffer.c:908: warning: unused variable 'winding' > vlib_buffer.c:908: warning: unused variable 'res' > > > the unused variables are just noise, but too much noise can hide a signal. > > > I ran the module on the Spearfish test dataset roads layer, all seemed to > work well. I noticed that the resulting areas were missing centroids and > the number of lines shrunk considerably with v.build.polylines. > > > > regards, > Hamish > > > > > > _______________________________________________ grass-dev mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/grass-dev
