#96: v.surf.bspline broken -----------------------+---------------------------------------------------- Reporter: cmbarton | Owner: grass-dev@lists.osgeo.org Type: defect | Status: reopened Priority: major | Milestone: 6.4.0 Component: Raster | Version: unspecified Resolution: | Keywords: Platform: All | Cpu: All -----------------------+---------------------------------------------------- Comment (by marisn):
Replying to [comment:7 neteler]: > I found suspicious code which was introduced in the last fix round. Commenting that out attributes are taken again. I don't understand the purpose of the part which I have commented in attached patch v.surf.bspline_fix_attribs.diff. AFAIK "type" is defined but not set. There is another "type" in main() - perhaps a different variable was supposed to be used to test against GV_POINTS? > > Markus Original code (almost) makes sense (r21982). {{{ /*type = Vect_read_line (&In, points, Cats, observ[i].lineID);*/ if ( !(type & GV_POINTS ) ) continue; }}} Still I have no idea how to fix this module (I'm lazy) (fix == does it needs that check or not). Also I looked at P_Read_Vector_Region_Map (lidarlib/zones.c) and it seemed somehow fishy - it reads vector line and then uses only first coordinate of that line, still as code lacks any comments about it's design specifics (and it has them i.e. as it crunches over all vector lines on every function call instad of using standart V_* functions) I can only suggest to somebody who understands that code to add comments and, probably, line type check. -- Ticket URL: <http://trac.osgeo.org/grass/ticket/96#comment:9> GRASS GIS <http://grass.osgeo.org>
_______________________________________________ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev