Soeren Gebbert wrote:
> JFYI: i have added a new option "selection" to r.neighbors.
A few points about the change:
1. Human-readable strings (option descriptions, messages) should be
localised with _(...).
2. There's no need to read the map using its native type
(CELL/FCELL/DCELL); reading as DCELL will suffice, and requires less
code. Better still, as you only care whether or not cells are null,
you can use Rast_get_null_value_row().
3. It reads the input a second time (at its native type, then converts
to DCELL) when the input row will already be in ncb.buf[ncb.dist] (as
DCELL).
4. There are a couple of deviations from the GRASS formatting
conventions (see tools/grass_indent.sh), specifically space between
"if" and "(" and "else" on a separate line to a preceding closing
brace.
Please check r40541.
--
Glynn Clements <[email protected]>
_______________________________________________
grass-dev mailing list
[email protected]
http://lists.osgeo.org/mailman/listinfo/grass-dev
