#974: [Patch] add option to d.vect to make symbol size proportionate to square root of size_column --------------------------+------------------------------------------------- Reporter: mlennert | Owner: [email protected] Type: enhancement | Status: closed Priority: normal | Milestone: 7.0.0 Component: Display | Version: unspecified Resolution: fixed | Keywords: Platform: Unspecified | Cpu: Unspecified --------------------------+------------------------------------------------- Changes (by mlennert):
* status: new => closed * resolution: => fixed Comment: Replying to [comment:1 hamish]: > I'm fine with the patch, a couple of comments though, > > - patches are '''''much''''' easier to review if they are kept to just the change you are talking about. ie gratuitous whitespace changes should be put in another patch if at all. signal:noise ratios & wasted time ... > > - please don't run the indent script unless you've added a bunch of new code which needs it. see the comments in the SUBMITTING file. Sorry, thought indent should always be run. But understand the point and won't do it again ;-) > - if using sqrt() please #include <math.h> > > - sqrt_flag->description: please split into two parts: short description on flag->label= line and "i.e." on flag->description= line (it becomes the tooltip). I've just committed a corrected version of the patch to trunk. Closing this and responding to the other issues on the mailing list. Moritz -- Ticket URL: <https://trac.osgeo.org/grass/ticket/974#comment:2> GRASS GIS <http://grass.osgeo.org>
_______________________________________________ grass-dev mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/grass-dev
