#1971: 64bit LFS support for G_ftell() and PRI_OFF_T gis.h
-------------------------------------------------+--------------------------
Reporter: hamish | Owner: grass-dev@…
Type: defect | Status: new
Priority: critical | Milestone: 6.4.3
Component: LibGIS | Version:
svn-develbranch6
Keywords: r.in.bin, LFS, G_ftell(), PRI_OFF_T | Platform: Linux
Cpu: x86-64 |
-------------------------------------------------+--------------------------
Comment(by hamish):
Glynn wrote:
> That's trunk.
ah, the history was imported as the file was recently copied from trunk.
ok, so 6.x is still LFS-on-demand. Added to devbr6 r.in.bin Makefile in
r56207. formal audit of all modules which might need it can come later.
Replying to [comment:6 glynn]:
> The G_* versions should use at least a long for offsets.
if I undo r45468 and add
{{{
#include <sys/types.h> /* for off_t */
}}}
to include/gisdefs.h, then devbr6 builds ok and r.in.bin + the >2GB file
imports ok for me on 64bit linux.
Glynn:
> The truncation to int was done in r45468, but I don't know why. Possibly
to
> avoid issues with off_t having different sizes in different files
(didn't LFS
> have to be enabled on a module-by-module basis in 6.x?).
Martin, do you remember why the change to int was needed? I can't find
anything in the archives about it.
thanks,
Hamish
--
Ticket URL: <https://trac.osgeo.org/grass/ticket/1971#comment:7>
GRASS GIS <http://grass.osgeo.org>
_______________________________________________
grass-dev mailing list
[email protected]
http://lists.osgeo.org/mailman/listinfo/grass-dev
