On Mon, Sep 8, 2014 at 6:06 PM, Glynn Clements <[email protected]> wrote:
> > Glynn Clements wrote: > > > But there's a rather more fundamental issue here: if G_find_file() is > > called for an element which isn't guaranteed to exist for every map, > > it will "find" the first map which actually contains that element, > > which isn't necessarily the same map as for the other elements. > > > > This doesn't affect the primary components of a map, because > > Rast_open_old() first determines the mapset, then passes an explicit > > mapset to the various G_open_* functions. > > > > So, I think that G_find_file() etc should only be used in "find mode" > > (with an empty mapset) for the "primary" element of a map (i.e. > > "cellhd" for raster maps, the map directory for vector maps). Other > > components should be located by first finding the mapset, then using > > the mapset to locate any additional components. > > Fixed (hopefully) in r61840. > > It seems that r61840 breaks a lot of tests. The yesterdays version (which is by chance r61839) is working. There are errors like ERROR: Raster map <elevation> not found for example for g.region and r.info. http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-09-08-07-00/report_for_nc_spm_08_grass7_nc/testfiles.html http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-09-09-07-00/report_for_nc_spm_08_grass7_nc/testfiles.html http://fatra.cnr.ncsu.edu/grassgistests/reports_for_date-2014-09-09-07-00/report_for_nc_spm_08_grass7_nc/raster/r.slope.aspect/test_r_slope_aspect/index.html > This change also reduces the number of warnings; a warning is only > generated when searching for the primary element. > > Given that it's a fairly fundamental change, it should be tested. > > OTOH, given that it fixes a fairly fundamental bug, it should go into > at least one beta prior to any final release. > > -- > Glynn Clements <[email protected]> > _______________________________________________ > grass-dev mailing list > [email protected] > http://lists.osgeo.org/mailman/listinfo/grass-dev >
_______________________________________________ grass-dev mailing list [email protected] http://lists.osgeo.org/mailman/listinfo/grass-dev
