On Thu, Aug 6, 2015 at 9:16 AM, Glynn Clements <[email protected]>
wrote:

>
> Vaclav Petras wrote:
>
> > However, now I see at least 3 tests which were not failing before [3, 4,
> > 5]. It seems like a trivial issue caused by some automatic changes
> (percent
> > operator is missing). This issue should be visible on any machine.
>
> The bug which is causing the test to fail has been present in
> v.db.addtable for 2 years (since r56701).
>
> If the tests only started failing recently, it can only be because of
> changes to how v.db.addtable was invoked.
>
> A database connection having a "schema" option where none existed
> before would seem likely. The error arises from:
>
>     if schema is not '':
>         table = '%s.%s' (schema, table)
>

The problem is related to the Python 3 support - the condition is wrong and
schema is now empty unicode string instead of empty string (coming from
db_connection()). I am not sure if unicode here is what we want, but that's
a different problem, the condition works for any empty string now.

Anna


> where "schema" is set by:
>
>     kv = grass.db_connection()
>     database = kv['database']
>     driver = kv['driver']
>     schema = kv['schema']
>
> --
> Glynn Clements <[email protected]>
> _______________________________________________
> grass-dev mailing list
> [email protected]
> http://lists.osgeo.org/mailman/listinfo/grass-dev
>
_______________________________________________
grass-dev mailing list
[email protected]
http://lists.osgeo.org/mailman/listinfo/grass-dev

Reply via email to