Hi, st 15. 5. 2019 v 18:20 odesÃlatel Vaclav Petras <wenzesl...@gmail.com> napsal: > Another thing is the need for new contributing guidelines. Git is not > Subversion and committing to master won't work (please, let me know if you > want me to show some examples). What other OSGeo projects are doing is that > contributing guidelines say that you should do pull request. It seems that > this is often preferred way even for core developers. From what I gathered > from a small sample of people at OSGeo sprint, the core devs don't go though > fork, but they do go through a branch. In GitHub, we can set "Require pull > request reviews before merging" and "Include administrators" for the master > branch to enforce that. I think we should do it at least at the beginning.
I tend to agree. Contributes with a write access should do PR for massive/tricky changes. It's perfect platform to discuss/improve changes before merging. Trivial changes can be committed/pushed directly, no PR needed. +1 my cent Ma -- Martin Landa http://geo.fsv.cvut.cz/gwiki/Landa http://gismentors.cz/mentors/landa _______________________________________________ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
