On 2015-08-25 1:18 PM, Élie Roux wrote:
Br. Samuel: there's quite a confusion in the code between eolshifts and bolshifts. These are two different things: eolshift is always active, while bolshift can be enabled or disabled, but it should be by \gresetbolshifts instead of \greeteolshifts, I think just renaming this macro (and a few minor things like \ifgre@eolshiftsenabled) should be enough. Also, the doc about the macro contains an error ("the a"), and is extremely blur. The description of what it does is here:https://github.com/gregorio-project/gregorio/blob/develop/tex/gregoriotex-syllable.tex#L528
After looking through the code, my analysis of the situation is a bit different. See https://github.com/gregorio-project/gregorio/pull/583 for more details (and how I fixed it).
Reading a little more, why is lie 846 of gregorio-syllable commented? I don't see any logic here...
I don't know. I didn't make any changes to the fact that it was commented out. I just renamed the function contained on that line. Browsing through the history it looks like you commented it out back in 2010 when end of line shifts were first introduced (commit 049b0ac806a67b967d9ae5d669ac8fef5960c471). Uncommentting it doesn't break any of the tests, so I'm not sure what the line is/was supposed to be doing.
✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝✝ Br. Samuel, OSB (R. Padraic Springuel) PAX ☧ ΧΡΙΣΤΟΣ _______________________________________________ Gregorio-users mailing list Gregorio-users@gna.org https://mail.gna.org/listinfo/gregorio-users
