On Fri, Jan 3, 2025 at 6:16 AM Sven Schreiber
<sven.schrei...@fu-berlin.de> wrote:
>
> Am 02.01.2025 um 22:43 schrieb Cottrell, Allin:
> > On Thu, Jan 2, 2025 at 12:40 PM Riccardo (Jack) Lucchetti
> > <p002...@staff.univpm.it> wrote:
> >> One of the things I'd do (but wouldn't fix the problem you spotted) is
> >> to change the code block
> >>
> >>
> >> maybe_extend_dummies(dset, oldn);
> >> if (dataset_is_time_series(dset)) {
> >> maybe_extend_lags(dset, oldn, dset->n - 1);
> >> }
> >>
> >>
> >> at line 1121 by moving the call to "maybe_extend_dummies(dset, oldn)"
> >> inside the if block: I don't think this should be done for a
> >> cross-sectional dataset (maybe for panel datasets...).
> > Yes, agreed. That's now done in git.
> >
> > Allin
>
> With "that" you mean that it's only done for time series, right?
> Referring to Jack's remark "wouldn't fix the problem you (= I) spotted".
I mean that extending periodic dummies is not done unless the dataset
is time series, but in addition it's not done unless $pd > 1, so the
change would fix the problem you reported.
Allin
_______________________________________________
Gretl-devel mailing list -- gretl-devel@gretlml.univpm.it
To unsubscribe send an email to gretl-devel-le...@gretlml.univpm.it
Website:
https://gretlml.univpm.it/postorius/lists/gretl-devel.gretlml.univpm.it/
