>> I just made a mistake while merging an update to grilo-plugins' DMAP
>> module. I used the following commit message when merging into master:
>> 
>>      dmap: add support for password-protected DAAP and DPAP shares
>> 
>> This should have been:
>> 
>>      dmap: update to libdmapsharing-4.0 API
>> 
>> I cannot force-push an amended message to fix this because of the
>> respoitory protections. Would someone else please change the former
>> to
>> the later?
> 
> No, nobody can, it's not allowed in GNOME git. You best bet would be to
> revert that commit, and file a new merge request with your changes.
> 
> I would have expected support for the new libdmapsharing not dropping
> support for the older version for example.

Again, sorry for the misstep. I acknowlege how busy everyone is, and I
in no way meant to imply otherwise.

I reverted the change with another commit, following the model of an
earlier and similar instance I found in the logs.

I did create a new merge request. I changed my approach so that
grilo-plugins should support compiling against any recent libdmapsharing
API. Here it is:

        https://gitlab.gnome.org/GNOME/grilo-plugins/merge_requests/70

Thank you,

-- 
Mike

:wq
_______________________________________________
grilo-list mailing list
grilo-list@gnome.org
https://mail.gnome.org/mailman/listinfo/grilo-list

Reply via email to