gbranden pushed a commit to branch master
in repository groff.

commit 8f5647956950a6cb5ac2b40704f2d73e57228a21
Author: G. Branden Robinson <[email protected]>
AuthorDate: Mon Jun 10 05:28:01 2024 -0500

    [mm]: Fix Savannah #65865 (cover sheet firm name).
    
    * contrib/mm/mm/0.MT: Move `cov@print-firm` call to where it works.
      Annotate the fairly subtle point revealed.
    
    Fixes <https://savannah.gnu.org/bugs/?65865>.  Problem appears to date
    back to commit bd5385e4ea, 17 November 1991 (groff 1.04, the first that
    shipped an implementation of mm).
---
 contrib/mm/ChangeLog |  9 +++++++++
 contrib/mm/mm/0.MT   | 10 +++++++++-
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/contrib/mm/ChangeLog b/contrib/mm/ChangeLog
index d7b7464eb..c5fe39603 100644
--- a/contrib/mm/ChangeLog
+++ b/contrib/mm/ChangeLog
@@ -1,3 +1,12 @@
+2024-06-10  G. Branden Robinson <[email protected]>
+
+       * mm/0.MT: Move `cov@print-firm` call to where it works.
+       Annotate the fairly subtle point revealed.
+
+       Fixes <https://savannah.gnu.org/bugs/?65865>.  Problem appears
+       to date back to commit bd5385e4ea, 17 November 1991 (groff 1.04,
+       the first that shipped an implementation of mm).
+
 2024-06-10  G. Branden Robinson <[email protected]>
 
        Regression-test Savannah #65865.
diff --git a/contrib/mm/mm/0.MT b/contrib/mm/mm/0.MT
index b06a4b8da..5dc19c22a 100644
--- a/contrib/mm/mm/0.MT
+++ b/contrib/mm/mm/0.MT
@@ -146,9 +146,17 @@ TM
 .ds cov*mt0-txt!3 ENGINEER'S NOTES
 .if d cov*default-firm .if !d cov*firm .ds cov*firm \\*[cov*default-firm]
 .\"
+.\" Note: The firm name (if any) is formatted _above_ the title and
+.\" other data, but the `AF` macro call defining it might be stuffed
+.\" inside the `TL` macro content, so its string won't be visible until
+.\" we format the title.  This is weird but DWB-compatible.
+.\"
+.\" (Technical details: DWB mm stores the title in a diversion.  groff
+.\" mm stores it in a macro, and only calling `AU` ends the macro
+.\" definition.)
 .if !d cov*mt-printed \{\
-.      cov@print-firm
 .      cov@print-title subject
+.      cov@print-firm
 .      cov@print-date date
 .      cov@print-authors from
 .      cov@print-abstract \\*[cov*abs-name]

_______________________________________________
Groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit

Reply via email to