gbranden pushed a commit to branch master
in repository groff.
commit a20851f6cb02e16fc552e80d5f9d9f74647a5df4
Author: G. Branden Robinson <[email protected]>
AuthorDate: Tue Jul 16 05:52:03 2024 -0500
[troff]: Simplify tautologus Boolean expression.
* src/roff/troff/number.cpp (is_valid_term): Trivially refactor;
simplify tautologus Boolean expression.
---
ChangeLog | 5 +++++
src/roff/troff/number.cpp | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index e18ceb871..210ab1ae1 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2024-07-15 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/number.cpp (is_valid_term): Trivially refactor;
+ simplify tautologus Boolean expression.
+
2024-07-15 G. Branden Robinson <[email protected]>
* src/roff/troff/input.cpp (token::description): Revise
diff --git a/src/roff/troff/number.cpp b/src/roff/troff/number.cpp
index 1c83c5316..b4be7a6d1 100644
--- a/src/roff/troff/number.cpp
+++ b/src/roff/troff/number.cpp
@@ -534,7 +534,7 @@ static bool is_valid_term(units *u, int scaling_unit,
case '=':
warning(WARN_SYNTAX, "empty left operand to '%1' operator", c);
*u = 0;
- return is_mandatory ? false : true;
+ return !is_mandatory;
default:
warning(WARN_NUMBER, "expected numeric expression, got %1",
tok.description());
_______________________________________________
Groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
