gbranden pushed a commit to branch master
in repository groff.
commit 567af8704bb8bd65b635b409d07858e36cb5d3b1
Author: G. Branden Robinson <[email protected]>
AuthorDate: Tue Aug 13 05:18:26 2024 -0500
src/roff/troff/node.cpp: Drop #include <unistd.h>.
* src/roff/troff/node.cpp: Drop Autoconf-guarded inclusion of
<unistd.h>. Judging by the groff 1.16 change log this appears to have
to do with the use of wait(2)-related macros, but dropping it doesn't
break a glibc-based build, and our "src/include/nonposix.h" header has
the same guarded inclusion, so we should still get it on unusual
systems. If a build breaks due to this change, we should document the
specific symbol(s) we need and/or rely on gnulib for them.
---
ChangeLog | 11 +++++++++++
src/roff/troff/node.cpp | 4 ----
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index bb8b6999e..810c547d4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2024-08-13 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/node.cpp: Drop Autoconf-guarded inclusion of
+ <unistd.h>. Jugding by the groff 1.16 change log this appears
+ to have to do with the use of wait(2)-related macros, but
+ dropping it doesn't break a glibc-based build, and our
+ "src/include/nonposix.h" header has the same guarded inclusion,
+ so we should still get it on unusual systems. If a build breaks
+ due to this change, we should document the specific symbol(s) we
+ need and/or rely on gnulib for them.
+
2024-08-13 G. Branden Robinson <[email protected]>
[troff]: Replace club with scalpel when including standard C
diff --git a/src/roff/troff/node.cpp b/src/roff/troff/node.cpp
index 211cfade7..4472c04dd 100644
--- a/src/roff/troff/node.cpp
+++ b/src/roff/troff/node.cpp
@@ -24,10 +24,6 @@ along with this program. If not, see
<http://www.gnu.org/licenses/>. */
#include <errno.h> // errno
-#ifdef HAVE_UNISTD_H
-#include <unistd.h>
-#endif
-
#include "dictionary.h"
#include "hvunits.h"
#include "stringclass.h"
_______________________________________________
Groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
