gbranden pushed a commit to branch master
in repository groff.
commit 955172d3c4965f4b0fd15877d01ea99a0ac73a47
Author: G. Branden Robinson <[email protected]>
AuthorDate: Sat Dec 21 16:55:27 2024 -0600
[groff]: Fix thinkos in new test.
* src/roff/groff/tests/artifacts/small-gnu-head.sh: Rename this...
* src/roff/groff/tests/artifacts/small-gnu-head.png: ...to this.
* src/roff/groff/tests/using-diversion-as-character-works.sh: Refer to
image file by correct name instead of neither of the foregoing.
This didn't actually break the test because all we're testing is the
correct sequencing of grout commands in GNU troff output, not whether
a graphic actually appears. But having a test script that doesn't
work right when you try it is a bad look.
---
ChangeLog | 16 ++++++++++++++++
.../artifacts/{small-gnu-head.sh => small-gnu-head.png} | Bin
.../groff/tests/using-diversion-as-character-works.sh | 4 ++--
3 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 68e406e86..32da6a849 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,19 @@
+2024-12-21 G. Branden Robinson <[email protected]>
+
+ [groff]: Fix thinkos in new test.
+
+ * src/roff/groff/tests/artifacts/small-gnu-head.sh: Rename
+ this...
+ * src/roff/groff/tests/artifacts/small-gnu-head.png: ...to this.
+ * src/roff/groff/tests/using-diversion-as-character-works.sh:
+ Refer to image file by correct name instead of neither of the
+ foregoing.
+
+ This didn't actually break the test because all we're testing is
+ the correct sequencing of grout commands in GNU troff output,
+ not whether a graphic actually appears. But having a test
+ script that doesn't work right when you try it is a bad look.
+
2024-12-19 G. Branden Robinson <[email protected]>
[groff]: Regression-test Savannah #66587.
diff --git a/src/roff/groff/tests/artifacts/small-gnu-head.sh
b/src/roff/groff/tests/artifacts/small-gnu-head.png
similarity index 100%
rename from src/roff/groff/tests/artifacts/small-gnu-head.sh
rename to src/roff/groff/tests/artifacts/small-gnu-head.png
diff --git a/src/roff/groff/tests/using-diversion-as-character-works.sh
b/src/roff/groff/tests/using-diversion-as-character-works.sh
index 3e8e4b3c4..3e47d6bdb 100755
--- a/src/roff/groff/tests/using-diversion-as-character-works.sh
+++ b/src/roff/groff/tests/using-diversion-as-character-works.sh
@@ -20,7 +20,7 @@
groff="${abs_top_builddir:-.}/test-groff"
-# Regression-test Savannah #6XXXX. Based on a reproducer by Peter
+# Regression-test Savannah #66587. Based on a reproducer by Peter
# Schaffter.
input='.
@@ -32,7 +32,7 @@ input='.
.di img-div
.ev img-div
.nf
-\X@pdf: pdfpic artifacts/GNU_head_small.pdf@
+\X@pdf: pdfpic artifacts/small-gnu-head.png@
.ev
.di
.
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
