gbranden pushed a commit to branch master
in repository groff.
commit 8b6ccbce48d84ad40d50dcadc9fe60436e13fc1d
Author: G. Branden Robinson <g.branden.robin...@gmail.com>
AuthorDate: Tue May 13 20:56:05 2025 -0500
src/roff/troff/env.cpp: Fix code style nit.
* src/roff/troff/env.cpp (compare_ranges, distribute_space)
(hyphen_trie::read_patterns_file): Favor C++-style `static_cast` and
`const_cast` over C-style omnipotent casts.
---
ChangeLog | 6 ++++++
src/roff/troff/env.cpp | 9 +++++----
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 3cf386e89..4735c73f9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2025-05-13 G. Branden Robinson <g.branden.robin...@gmail.com>
+
+ * src/roff/troff/env.cpp (compare_ranges, distribute_space)
+ (hyphen_trie::read_patterns_file): Favor C++-style `static_cast`
+ and `const_cast` over C-style omnipotent casts.
+
2025-05-07 G. Branden Robinson <g.branden.robin...@gmail.com>
* tmac/doc.tmac (Bd): Fix code style nit. Perform "strict"
diff --git a/src/roff/troff/env.cpp b/src/roff/troff/env.cpp
index 0389523dc..dcb012c26 100644
--- a/src/roff/troff/env.cpp
+++ b/src/roff/troff/env.cpp
@@ -234,7 +234,8 @@ extern "C" {
int compare_ranges(const void *p1, const void *p2)
{
- return ((size_range *)p1)->min - ((size_range *)p2)->min;
+ return ( static_cast<size_range *>(const_cast<void *>(p1))->min
+ - static_cast<size_range *>(const_cast<void *>(p2))->min);
}
}
@@ -2207,8 +2208,8 @@ static bool distribute_space(node *nd, int nspaces,
if (!force_reverse_node_list && spread_limit >= 0
&& desired_space.to_units() > 0) {
hunits em = curenv->get_size();
- double Ems = (double)desired_space.to_units() / nspaces
- / (em.is_zero() ? hresolution : em.to_units());
+ double Ems = static_cast<double>(desired_space.to_units() / nspaces
+ / (em.is_zero() ? hresolution : em.to_units()));
if (Ems > spread_limit)
output_warning(WARN_BREAK, "spreading %1m per space", Ems);
}
@@ -4197,7 +4198,7 @@ void hyphen_trie::read_patterns_file(const char *name,
int append,
if (i > 0) {
if (have_patterns || is_final_pattern || is_traditional) {
for (int j = 0; j < i; j++)
- buf[j] = hpf_code_table[(unsigned char)buf[j]];
+ buf[j] = hpf_code_table[static_cast<unsigned char>(buf[j])];
insert_pattern(buf, i, num);
is_final_pattern = false;
}
_______________________________________________
groff-commit mailing list
groff-commit@gnu.org
https://lists.gnu.org/mailman/listinfo/groff-commit
