gbranden pushed a commit to branch master
in repository groff.

commit aca2c64dd0e6633e33e8543e10ad063bd0096ddb
Author: G. Branden Robinson <g.branden.robin...@gmail.com>
AuthorDate: Thu Jul 24 12:33:50 2025 -0500

    [man]: Revert a bad idea from yesterday.
    
    * tmac/an.tmac (an*input-trap): Stop calling
      `an*reset-paragraph-parameters`, instead invoking `ft`, `ps`, and `vs`
      directly.  The former macro is indeed responsible for a "paragraph
      reset", but this input trap is also (and predominantly) used by macros
      that perform "inline" style changes (`B`, `I`, `SM`, and so on).  A
      paragraph reset can alter adjustment and hyphenation modes, and we
      _don't_ want that here--it makes synopses format incorrectly.
    
    Partially reverts commit 6fc5ea05dd, yesterday.
    
    Annotate a potentially less dangerous refactoring.
---
 ChangeLog    | 11 +++++++++++
 tmac/an.tmac |  6 +++++-
 2 files changed, 16 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index ce27da5e7..2acbd661e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2025-07-24  G. Branden Robinson <g.branden.robin...@gmail.com>
+
+       * tmac/an.tmac (an*input-trap): Stop calling
+       `an*reset-paragraph-parameters`, instead invoking `ft`, `ps`,
+       and `vs` directly.  The former macro is indeed responsible for a
+       "paragraph reset", but this input trap is also (and
+       predominantly) used by macros that perform "inline" style
+       changes (`B`, `I`, `SM`, and so on).  A paragraph reset can
+       alter adjustment and hyphenation modes, and we _don't_ want that
+       here--it makes synopses format incorrectly.
+
 2025-07-24  G. Branden Robinson <g.branden.robin...@gmail.com>
 
        * tmac/tests/an-ext_synopses_do_not_automatically_adjust.sh: Add
diff --git a/tmac/an.tmac b/tmac/an.tmac
index e3f1783e0..0a7326a42 100644
--- a/tmac/an.tmac
+++ b/tmac/an.tmac
@@ -679,7 +679,11 @@ contains unsupported escape sequence
 .  nr an-devtag-needs-end-of-heading 0
 .  if \\n[an-devtag-needs-second-column] .DEVTAG-COL 2
 .  nr an-devtag-needs-second-column 0
-.  an*reset-paragraph-parameters
+.  \" TODO: We might factor this into `an*reset-typeface-parameters` and
+.  \" have `an*reset-paragraph-parameters` call it as well.
+.  ft R
+.  ps \\n[PS]u
+.  vs \\n[VS]u
 .  if \\n[an-need-break] \{\
 .    br
 .    nr an-need-break 0

_______________________________________________
groff-commit mailing list
groff-commit@gnu.org
https://lists.gnu.org/mailman/listinfo/groff-commit

Reply via email to