gbranden pushed a commit to branch master
in repository groff.

commit 5c3c2fcf744c0f0140008c8971d80a2f0d24742d
Author: G. Branden Robinson <[email protected]>
AuthorDate: Thu Nov 13 07:23:44 2025 -0600

    [troff]: Adjust wording of syntax warning.
    
    * src/roff/troff/input.cpp (is_conditional_expression_true): Tweak
      wording of syntax warning thrown only in compatibility mode.  Say that
      the conditional expression operator is "not portable to AT&T troff",
      for parallel phrasing with the escape sequence warning added in commit
      589a724eca, 2 November, and because a person authoring or formatting a
      document presumably knows whether they're using compatibility mode.
      (If they don't know, they can find out with `.tm compatibility mode is
      \n(.C`.)  Prompted by discussion with James Youngman.
    
    ANNOUNCE: Acknowledge James.
---
 ANNOUNCE                 |  1 +
 ChangeLog                | 12 ++++++++++++
 src/roff/troff/input.cpp |  4 ++--
 3 files changed, 15 insertions(+), 2 deletions(-)

diff --git a/ANNOUNCE b/ANNOUNCE
index d59f0b7b3..3f877984d 100644
--- a/ANNOUNCE
+++ b/ANNOUNCE
@@ -188,6 +188,7 @@ Helge Kreutzmann
 Ian Ropers
 Ingo Schwarze
 James Cloos
+James Youngman
 Jeff Conrad
 Joerg van den Hoff
 Jonathan Gray
diff --git a/ChangeLog b/ChangeLog
index 8dea8432b..b2db74c45 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2025-11-13  G. Branden Robinson <[email protected]>
+
+       * src/roff/troff/input.cpp (is_conditional_expression_true):
+       Tweak wording of syntax warning thrown only in compatibility
+       mode.  Say that the conditional expression operator is "not
+       portable to AT&T troff", for parallel phrasing with the escape
+       sequence warning added in commit 589a724eca, 2 November, and
+       because a person authoring or formatting a document presumably
+       knows whether they're using compatibility mode.  (If they don't
+       know, they can find out with `.tm compatibility mode is \n(.C`.)
+       Prompted by discussion with James Youngman.
+
 2025-11-09  G. Branden Robinson <[email protected]>
 
        * src/libs/libgroff/color.cpp (color::get_rgb, color::get_cmy)
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 9a9ba8355..c2bbcc088 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -6915,8 +6915,8 @@ static bool is_conditional_expression_true()
     case 'r':
     case 'v':
       warning(WARN_SYNTAX,
-             "conditional expression operator '%1' used in"
-             " compatibility mode",
+             "conditional expression operator '%1' is not portable to"
+             " AT&T troff",
              c);
              // TODO: "; treating as output comparison delimiter", c);
       break;

_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit

Reply via email to