gbranden pushed a commit to branch master
in repository groff.
commit 67800dc4923a248daaae47549d8d10e79ac26709
Author: G. Branden Robinson <[email protected]>
AuthorDate: Tue Nov 25 23:59:10 2025 -0600
[troff]: Fix code style nits.
* src/roff/troff/input.cpp (do_name_test, return_macro_request): Rather
than letting an input character pun down to a Boolean value, compare
it to an appropriate constant literal.
---
ChangeLog | 7 +++++++
src/roff/troff/input.cpp | 4 ++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 8e6f20c97..b96e25100 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2025-11-25 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/input.cpp (do_name_test, return_macro_request):
+ Fix code style nits. Rather than letting an input character pun
+ down to a Boolean value, compare it to an appropriate constant
+ literal.
+
2025-11-25 G. Branden Robinson <[email protected]>
* src/roff/troff/input.cpp (read_identifier, do_get_long_name)
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 3f9ae7640..d4652c329 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -1786,7 +1786,7 @@ static const char *do_name_test() // \A
if (tok == start_token
&& (want_att_compat || input_stack::get_level() == start_level))
break;
- if (!tok.ch())
+ if (tok.ch() == 0U)
got_bad_char = true;
got_some_char = true;
}
@@ -3240,7 +3240,7 @@ void exit_request()
void return_macro_request()
{
- if (has_arg() && tok.ch())
+ if (has_arg() && (tok.ch() != 0U))
input_stack::pop_macro();
input_stack::pop_macro();
tok.next();
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
