gbranden pushed a commit to branch master
in repository groff.
commit 7825b80f5fc0a4efd7e2b2fb45a5284f81c97ee4
Author: G. Branden Robinson <[email protected]>
AuthorDate: Thu Nov 27 02:16:17 2025 -0600
[troff]: Modestly refactor (8/8).
* src/roff/troff/input.cpp (read_drawing_command): Store return value of
`tok.ch()` in local variable of `int`, not `unsigned char`, type.
---
ChangeLog | 2 ++
src/roff/troff/input.cpp | 6 ++++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 470297805..20f232505 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -21,6 +21,8 @@
* src/roff/troff/reg.cpp (assign_register_format_request):
* src/roff/troff/number.cpp (is_valid_term):
* src/roff/troff/input.cpp (is_conditional_expression_true):
+ * src/roff/troff/input.cpp (is_conditional_expression_true)
+ (read_drawing_command):
Store return value of `tok.ch()` in local variable of `int`, not
`char`, type.
* src/roff/troff/env.cpp: Retype global `TAB_REPEAT_CHAR` from
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 8ddf03597..22d9112ae 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -10335,10 +10335,12 @@ static void
read_drawing_command_color_arguments(token &start)
error("missing color scheme");
return;
}
- unsigned char scheme = tok.ch();
+ // safely compares to char literals; TODO: grochar
+ int scheme = tok.ch();
tok.next();
color *col = 0 /* nullptr */;
- char end = start.ch();
+ // TODO: grochar
+ int end = start.ch();
switch (scheme) {
case 'c':
col = read_cmy(end);
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
