gbranden pushed a commit to branch master
in repository groff.
commit c545d5192dcf7beb643c8ce362fa3b17fcf1d033
Author: G. Branden Robinson <[email protected]>
AuthorDate: Mon Dec 1 17:44:45 2025 -0600
[troff]: Fix Savannah #67570.
* src/roff/troff/input.cpp (charinfo::get_flags): Fix inadvertent
regression caused by fumbled refactoring, wherein I inexplicably
mistook a Boolean-valued return type for an `int`-valued one.
(`contains()` sounds Boolean to me now, in the cold light of day.)
Fixes <https://savannah.gnu.org/bugs/?67570>. Thanks to Dave Kemper for
the report. Problem introduced by me in commit 77d8f728d, 4 September.
---
ChangeLog | 12 ++++++++++++
src/roff/troff/input.cpp | 2 +-
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index be5a432e6..542134e94 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2025-12-01 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/input.cpp (charinfo::get_flags): Fix
+ inadvertent regression caused by fumbled refactoring, wherein I
+ inexplicably mistook a Boolean-valued return type for an
+ `int`-valued one. (`contains()` sounds Boolean to me now, in
+ the cold light of day.)
+
+ Fixes <https://savannah.gnu.org/bugs/?67570>. Thanks to Dave
+ Kemper for the report. Problem introduced by me in commit
+ 77d8f728d, 4 September.
+
2025-12-01 G. Branden Robinson <[email protected]>
[groff]: Regression-test Savannah #67570.
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index ee070db48..3c1602a8b 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -10731,7 +10731,7 @@ void charinfo::get_flags()
// troff's dictionary types use a pre-STL approach to containers.
while (iter.get(&s, reinterpret_cast<void **>(&ci))) {
assert(!s.is_null());
- if (ci->contains(get_unicode_mapping() >= 0)) {
+ if (ci->contains(get_unicode_mapping())) {
#if defined(DEBUGGING)
if (want_html_debugging)
fprintf(stderr, "charinfo::get_flags %p %s %d\n",
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
