gbranden pushed a commit to branch master
in repository groff.
commit 000f20dc7426a6e8954298e3d08444be1d9ee85d
Author: G. Branden Robinson <[email protected]>
AuthorDate: Wed Mar 18 07:34:56 2026 -0500
[troff]: Trivially refactor (1/3).
* src/roff/troff/input.cpp: Rename global array `warning_table` to
`warning_map`, for greater precision.
(lookup_warning): Update dereference site. Also rename this...
(lookup_warning_by_name): ...to this.
(enable_warning, disable_warning): Update call sites of foregoing.
---
ChangeLog | 11 +++++++++++
src/roff/troff/input.cpp | 16 ++++++++--------
2 files changed, 19 insertions(+), 8 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 6256dc663..5346bc9a4 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2026-03-18 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/input.cpp: Trivially refactor. Rename global
+ array `warning_table` to `warning_map`, for greater precision.
+ (lookup_warning): Update dereference site. Also rename this...
+ (lookup_warning_by_name): ...to this.
+ (enable_warning, disable_warning): Update call sites of
+ foregoing.
+ (struct warning_category): Rename member variable `set` to
+ `bitset`, for clarity.
+
2026-03-17 G. Branden Robinson <[email protected]>
[grotty]: Revise dynamic memory allocation strategy. The
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 2ce7f8c8f..0f3065253 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -10610,8 +10610,8 @@ static void read_drawing_command_color_arguments(token
&start)
static const struct warning_category {
const char * const name;
- const unsigned int set;
-} warning_table[] = {
+ const unsigned int bitset;
+} warning_map[] = {
{ "char", WARN_CHAR },
{ "range", WARN_RANGE },
{ "break", WARN_BREAK },
@@ -10636,17 +10636,17 @@ static const struct warning_category {
{ "default", DEFAULT_WARNING_CATEGORY_SET },
};
-static unsigned int lookup_warning(const char *name)
+static unsigned int lookup_warning_by_name(const char *name)
{
- for (unsigned int i = 0U; i < countof(warning_table); i++)
- if (strcmp(name, warning_table[i].name) == 0)
- return warning_table[i].set;
+ for (unsigned int i = 0U; i < countof(warning_map); i++)
+ if (strcmp(name, warning_map[i].name) == 0)
+ return warning_map[i].bitset;
return 0U;
}
static void enable_warning(const char *name)
{
- unsigned int category = lookup_warning(name);
+ unsigned int category = lookup_warning_by_name(name);
if (category != 0U)
desired_warnings |= category;
else
@@ -10655,7 +10655,7 @@ static void enable_warning(const char *name)
static void disable_warning(const char *name)
{
- unsigned int category = lookup_warning(name);
+ unsigned int category = lookup_warning_by_name(name);
if (category != 0U)
desired_warnings &= ~category;
else
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
