gbranden pushed a commit to branch master
in repository groff.
commit cf6e301181413196c8dfd4aa1fc641cad3d60e8a
Author: G. Branden Robinson <[email protected]>
AuthorDate: Sun Mar 22 15:23:42 2026 -0500
[troff]: Reword error diagnostic message.
* src/roff/troff/input.cpp (substring_request): Revise wording of error
diagnostic. The use of the term "extract" could be taken to mean that
the original string was left intact, which is not the case; if the
operation proceeds, it edits the string/macro/diversion's contents in
place.
---
ChangeLog | 8 ++++++++
src/roff/troff/input.cpp | 3 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index 24c0b3f0b..21c4c6308 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2026-03-22 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/input.cpp (substring_request): Revise wording
+ of error diagnostic. The use of the term "extract" could be
+ taken to mean that the original string was left intact, which is
+ not the case; if the operation proceeds, it edits the string/
+ macro/diversion's contents in place.
+
2026-03-20 G. Branden Robinson <[email protected]>
* src/roff/groff/tests/ab-request-works.sh: Conform better to
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 1d373b181..55de22544 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -5813,7 +5813,8 @@ void substring_request()
request_or_macro *p = lookup_request(s);
macro *m = p->to_macro();
if (0 /* nullptr */ == m)
- error("cannot extract substring of request '%1'", s.contents());
+ error("cannot perform substring operation on request '%1'",
+ s.contents());
else {
int end = -1;
if (!has_arg() || read_integer(&end)) {
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
