gbranden pushed a commit to branch master
in repository groff.
commit 73ff1a04626581eee4c8e3051c450c83b5a2e360
Author: G. Branden Robinson <[email protected]>
AuthorDate: Fri Mar 20 17:45:40 2026 -0500
src/roff/troff/input.cpp: Trivially refactor.
* src/roff/troff/input.cpp (chop_macro): Arrange equality comparison to
avoid inadvertent lvalue assignment.
---
ChangeLog | 5 +++++
src/roff/troff/input.cpp | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index 796b2720f..83517af9c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2026-03-20 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/input.cpp (chop_macro): Arrange equality
+ comparisons to avoid inadvertent lvalue assignment.
+
2026-03-20 G. Branden Robinson <[email protected]>
* src/roff/troff/input.cpp (chop_macro): Drop error diagnostic
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 691f52736..80b12390a 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -5716,7 +5716,7 @@ void chop_macro()
break;
contains_mode_tokens = false;
m->len -= 1;
- if (m->len == 0)
+ if (0 == m->len)
break;
}
assert(m->len != 0);
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
