gbranden pushed a commit to branch master
in repository groff.
commit 29765f6d65eb06acaecd6615a85c6a4f8accd497
Author: G. Branden Robinson <[email protected]>
AuthorDate: Wed Apr 1 04:35:12 2026 -0500
[troff]: Fix Savannah #68202 (1/2).
* src/roff/troff/env.cpp (add_hyphenation_exception_words_request): Stop
throwing assert(3)ion if an argument contains a non-character. The
assertion is invalidated by plausible user input like:
`.hw baz\%qux`
and similar.
Begins fixing <https://savannah.gnu.org/bugs/?68202>. Problem
introduced by me in commit effd6835dc, 19 November.
---
ChangeLog | 12 ++++++++++++
src/roff/troff/env.cpp | 2 --
2 files changed, 12 insertions(+), 2 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 9263eaf49..ae7fbb895 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2026-04-01 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/env.cpp
+ (add_hyphenation_exception_words_request): Stop throwing
+ assert(3)ion if an argument contains a non-character. The
+ assertion is invalidated by plausible user input like:
+ `.hw baz\%qux`
+ and similar.
+
+ Begins fixing <https://savannah.gnu.org/bugs/?68202>. Problem
+ introduced by me in commit effd6835dc, 19 November.
+
2026-04-01 G. Branden Robinson <[email protected]>
[man]: Trivially refactor.
diff --git a/src/roff/troff/env.cpp b/src/roff/troff/env.cpp
index 04cc77a22..75dc1d747 100644
--- a/src/roff/troff/env.cpp
+++ b/src/roff/troff/env.cpp
@@ -3904,8 +3904,6 @@ static void add_hyphenation_exception_words_request()
&& !tok.is_eof()) {
charinfo *ci = tok.get_charinfo(true /* required */);
if (0 /* nullptr */ == ci) {
- assert(0 == "attempted to use token without charinfo in"
- " hyphenation exception word");
skip_line();
return;
}
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
