gbranden pushed a commit to branch master
in repository groff.
commit af60d3be2baba7621e9f329160d39c16a6c1370b
Author: G. Branden Robinson <[email protected]>
AuthorDate: Tue Apr 14 00:40:08 2026 -0500
src/roff/troff/env.cpp: Annotate future direction.
---
man/groff.7.man | 3 +++
src/roff/troff/env.cpp | 4 ++++
2 files changed, 7 insertions(+)
diff --git a/man/groff.7.man b/man/groff.7.man
index e8075ba91..c0910fda7 100644
--- a/man/groff.7.man
+++ b/man/groff.7.man
@@ -5042,6 +5042,9 @@ it reads
each
.IR s i
in copy mode.
+.\" XXX: ...hinting at an implementation wart. The request handler uses
+.\" `read_rest_of_line_as_argument()` rather than calling a dedicated
+.\" read-integer-range function, which we don't have.
.
.TPx
.REQ .so file
diff --git a/src/roff/troff/env.cpp b/src/roff/troff/env.cpp
index 5de43374d..dae553d09 100644
--- a/src/roff/troff/env.cpp
+++ b/src/roff/troff/env.cpp
@@ -1418,6 +1418,10 @@ static void override_available_type_sizes_request() //
.sizes
skip_line();
return;
}
+ // TODO: Move these fiddly details into a function that reads a
+ // decimal integer or range thereof.
+ // TODO: Migrate this heap array to std::vector<int>.
+ // XXX: But what to do about the ranges?
int n = 16;
int *sizes = new int[n]; // C++03: new int[n]();
(void) memset(sizes, 0, (n * sizeof(int)));
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit