gbranden pushed a commit to branch master
in repository groff.
commit 93e8746162e068e35595a59197b493c6e920986a
Author: G. Branden Robinson <[email protected]>
AuthorDate: Fri Apr 17 07:27:50 2026 -0500
src/roff/troff/env.cpp: Trivially refactor (3/3).
* src/roff/troff/env.cpp: We're pretty close to exclusive use of
function names starting with "read_" for input stream reading
operations; that is, interpretation of *roff language. This change
moves us closer to that goal.
(read_hyphenation_patterns_from_file): Rename this...
(update_hyphenation_patterns_from_file): ...to this.
(load_hyphenation_patterns_from_file_request)
(append_hyphenation_patterns_from_file_request): Update call sites.
---
ChangeLog | 9 +++++++++
src/roff/troff/env.cpp | 6 +++---
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 2166defb0..7f6f37ba9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2026-04-17 G. Branden Robinson <[email protected]>
+
+ * src/roff/troff/env.cpp (class hyphen_trie): Trivially
+ refactor. Rename member function `read_patterns_file()` to
+ `interpret_patterns_file()`. We're pretty close to exclusive
+ use of function names starting with "read_" for input stream
+ reading operations; that is, interpretation of *roff language.
+ This change moves us closer to that goal.
+
2026-04-17 G. Branden Robinson <[email protected]>
* src/roff/troff/env.cpp: Trivially refactor. Rename
diff --git a/src/roff/troff/env.cpp b/src/roff/troff/env.cpp
index 67ff07e03..9121bb98c 100644
--- a/src/roff/troff/env.cpp
+++ b/src/roff/troff/env.cpp
@@ -4858,7 +4858,7 @@ static void hyphenate(hyphen_list *h, unsigned int flags)
}
}
-static void read_hyphenation_patterns_from_file(bool appending)
+static void update_hyphenation_patterns_from_file(bool appending)
{
char *filename = read_rest_of_line_as_argument();
if (filename != 0 /* nullptr */) {
@@ -4878,7 +4878,7 @@ static void load_hyphenation_patterns_from_file_request()
// .hpf
skip_line();
return;
}
- read_hyphenation_patterns_from_file(false /* appending */);
+ update_hyphenation_patterns_from_file(false /* appending */);
skip_line();
}
@@ -4890,7 +4890,7 @@ static void
append_hyphenation_patterns_from_file_request() // .hpfa
skip_line();
return;
}
- read_hyphenation_patterns_from_file(true /* appending */);
+ update_hyphenation_patterns_from_file(true /* appending */);
skip_line();
}
_______________________________________________
groff-commit mailing list
[email protected]
https://lists.gnu.org/mailman/listinfo/groff-commit
